hongjingzhou

Hongjing Zhou

@hongjingzhou
GitHub Profile
collaborative and explanatory
Pragmatic and context-aware reviewer who provides concise, actionable feedback with a focus on practical implementation details. Tends to explain intentional design decisions and offers specific suggestions for improvement while maintaining a collaborative tone.
367
Comments
282
PRs
14
Repos
61
Avg Chars
2
Harshness

Personality

Pragmatic and solution-oriented Collaborative and explanatory Detail-oriented with architectural awareness Patient with debugging context Proactive about breaking changes Respectful of team input Security and compatibility conscious Process-improvement minded

Greatest Hits

"this is intentional because cached room/package should exist in google center already"
"this is for debug only, and currently, the consumer only handle one sqs message once"
"looks good to me, but please double-check the points flagged by coderabbitai"
"revert this local debug code"
"use _xxx for 'private' method"

Focus Areas

Common Phrases

"this is intentional" "please check" "looks good to me" "thank you" "will be removed after test done" "for debug only" "please double check" "use logger instead of print" "revert this local debug code" "good point, will do later" "no need to use proxy here?" "move these" "use _xxx for 'private' method" "forgot to checkin" "where is this logic?"

Sentiment Breakdown

neutral
108
positive
15
constructive
11
questioning
10
harsh_questioning
1

Review Outcomes

APPROVED
228
CHANGES_REQUESTED
6
COMMENTED
2
DISMISSED
1

Most Reviewed Authors

yellowland
105
hongjingzhou
96
cxsun123
73
daisylicode
17
TinyGambe
17
paveldudka
10
frankfeng98
8
ayc1
6
zhenzhaoya
4
akuzminsky
4

Spiciest Comments

agentql-apps/#82 [view]
> Each customer is an isolated environment and we don't intend to share anything between different customers @thakkerurvish in my initial and current implementation, `cooley` and `bain` do share some logic within the `common` folder. as you can see, both `cooley` and `bain` were broken after the top level `pyproject.toml` was removed by b5cb530 The ideal approach might be to move the functionality in common to a separate git subrepo, or place it in a separate tf-common-xxx repository. How

AI Persona Prompt

You are @hongjingzhou, a pragmatic and collaborative code reviewer who focuses on practical implementation details and architectural clarity. Your review style is concise but thorough, often providing context for intentional design decisions. You frequently use phrases like 'this is intentional', 'looks good to me', 'please check', and 'thank you' to maintain a collaborative tone. You have a keen eye for debugging code that shouldn't make it to production, often commenting 'this is for debug only' or 'revert this local debug code'. You care deeply about proper configuration management, suggesting centralized config files and proper environment variable usage. You advocate for good naming conventions, recommending underscore prefixes for private methods and descriptive function names. You're proactive about identifying breaking changes and their deployment impact, providing detailed analysis when you spot potential issues. You often acknowledge good suggestions from automated tools like CodeRabbit, saying 'please double-check the points flagged by coderabbitai'. You maintain respect for team members, frequently thanking contributors and explaining the reasoning behind your feedback. Your comments are usually short and direct, averaging around 57 characters, but you can provide detailed technical analysis when critical issues are found. You tend to approve most PRs (82% approval rate) while providing constructive feedback for improvement. Focus on practical concerns over theoretical perfection, and always explain the 'why' behind your suggestions.

Recent Comments (145 total)

agentql-apps/#662 DE-921 Add CI workflow to build and push Doordash scraper to ECR · .github/workflows/doordash_ecr_build_push.yml [view]
pr description updated
agentql-apps/#660 HAIL MARY - Aggressive scheduling for PART1 reservation systems [view]
LGTM
agentql-apps/#657 Add script to build hotel_property_data_test.csv [view]
LGTM
agentql-apps/#646 Append delivery fee to table cart_checkout_fees · apps/doordash/tests/test_fees.py [view]
logger initialized but unused?
agentql-apps/#626 Fix vulnerability in `cryptography` library · apps/doordash/pyproject.toml [view]
cc @cxsun123 please be noted: > Major version upgrade: test compatibility with snowflake-connector-python 4.0.0 breaking changes.
agentql-apps/#619 De-899 Add logs for scraping data from cache in Databricks [view]
Consider to use StrEnum instead of hardcode value.
agentql-apps/#614 DE-883: Add cron job filter for YADOSYS hotels · apps/google_hotel_sqs/app/producer/sqs_producer.py [view]
this is a testing logic, will be removed after test done.
agentql-apps/#606 DE-884 Add dynamic concurrency limit based on reservation system · apps/google_hotel_sqs/app/services/orchestrator_service.py [view]
this is for debug only, and currently, the consumer only handle one sqs message once.
agentql-apps/#584 Add Databricks cache for Google Hotel ML mode · apps/google_hotel_sqs/app/services/orchestrator_service.py [view]
this is intented because cached room/package should exist in google center already
agentql-apps/#584 Add Databricks cache for Google Hotel ML mode [view]
### Code review Found 2 issues: 1. **Cached data silently dropped from output** - When only cached data is available (implicit requests), all rooms/packages have empty names by design (line 242: `name="", # use empty name to indicate cached data`). However, the filtering at lines 203-204 removes all items with empty names. This means if only cached data exists for a room/package, it will be com
agentql-apps/#551 resume toyoko inn · apps/google_hotel_sqs/app/producer/config/toyoko_inn_tasks.py [view]
6, 7 is correct, we only check the time when the producer is started.
agentql-apps/#494 Daisy/zebra scraper · apps/zebra/app/model/general_models.py [view]
use str | None instead of Optional[str]
agentql-apps/#498 DE-730 Use IPRoyal proxy on production [view]
looks good to me, but please double check coderabbitai's suggestion
agentql-apps/#496 Scrape rental car list for GetGo [view]
looks good to me, but please double-check the points flagged by coderabbitai to see if any of them would be worth adjusting.
agentql-apps/#459 ENG-10517: Add google hotel crawl producer that sources crawl targets from kinesis stream [view]
Looks good to me, thank you Steve