keell0renz

Bohdan Agarkov

@keell0renz · Generative AI and Full-Stack Developer
GitHub Profile
conversational and collaborative with occasional frustration
Collaborative and communicative developer who primarily reviews their own code. Engages in detailed technical discussions and is receptive to feedback from senior team members. Shows persistence in problem-solving and isn't afraid to admit when something is confusing or needs improvement.
161
Comments
31
PRs
2
Repos
174
Avg Chars
3
Harshness

Personality

Highly communicative and verbose Receptive to feedback and willing to admit mistakes Persistent problem-solver who doesn't give up easily Sometimes frustrated by tooling issues (especially black formatting) Creative and playful (writes Russian poetry in PR comments) Pragmatic about code quality vs shipping speed Honest about limitations and knowledge gaps Collaborative team player

Greatest Hits

"Thanks! I have overlooked."
"Will be done soon."
"I suggest we just..."
"Does it sound reasonable?"
"Not ready yet!"
"I cant stand this style check."
"What are my plans regarding..."
"Thanks for the feedback!"

Focus Areas

Common Phrases

"Will be done" "Thanks!" "I will" "Sorry" "I suggest" "Let me" "What are my plans" "I think" "Thanks for the feedback!" "Give me" "I have" "Does it sound reasonable?" "Not ready yet!" "Will figure out" "Got it"

Sentiment Breakdown

positive
9
neutral
119
questioning
13
constructive
5
harsh_questioning
3
critical
2
harsh
3
very_positive
1

Review Outcomes

COMMENTED
2
APPROVED
12

Most Reviewed Authors

keell0renz
146
paveldudka
9
frankfeng98
5
KateZhang98
1

Spiciest Comments

agentql-client/#465 [view]
> before we have everyone on the same page that automatic idle detection will be removed, Im not comfortable approving this PR > > Please conduct an analysis what the current problem is, bring it up to a broader group discussion, get an alignment and only then remove an important piece of functionality. > > > > Reasons like "its too weird" or "I don't understand it" are not valid reasons to remove it Thank you! You are right. Will be done soon.
agentql-client/#465 [view]
> > I would first ship this PR, and later open a new one to fix the old code. It will be faster. > > I'd argue it's faster to test your new behavior in an already workign setup, rather than in the code that you're writing and that can be broken in many ways. It is not a new behavior. This PR is about adding wait for page ready state to locators. Let's first finish this, and after that we will fix the main one.
agentql-client/#463 · test/agentql/web/playwright_smart_locator_async_test.py [view]
There is no need for it because as I said, the model just returns dict with text value "none", so it has absolutely nothing to do with the code logic but with the model.
agentql-client/#466 [view]
@paveldudka I cant stand this style check. Locally black does not format what the CI CD black wants. Can we just ignore it?
agentql-client/#466 [view]
> @paveldudka I cant stand this style check. Locally black does not format what the CI CD black wants. Can we just ignore it? Just take a look what it is sad about now. That's nonsense.
agentql-client/#466 [view]
> > @paveldudka I cant stand this style check. Locally black does not format what the CI CD black wants. Can we just ignore it? > > > > absolutely not. > > Just patched your PR and VSCode formats everything correctly. This indicates that your local setup doesn't use formatting settings recommended by the project. > > > > These settings seem to work for everyone else on the team Thank you! Where can I find settings? I just use poetry run black src/
agentql-client/#466 [view]
> > > > @paveldudka I cant stand this style check. Locally black does not format what the CI CD black wants. Can we just ignore it? > > > > > > > > > > > > absolutely not. > > > > Just patched your PR and VSCode formats everything correctly. This indicates that your local setup doesn't use formatting settings recommended by the project. > > > > These settings seem to work for everyone else on the team > > > > > > Thank you! Where can I find settings? I just use poetry run black src/ >
agentql-client/#466 [view]
> > > > > > @paveldudka I cant stand this style check. Locally black does not format what the CI CD black wants. Can we just ignore it? > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > absolutely not. > > > > > > > > > > > > > > Just patched your PR and VSCode formats everything correctly. This indicates that your local setup doesn't use formatting settings recommended by the project. > > > > > > > > > > > > > > These settings seem to w

AI Persona Prompt

You are @keell0renz, a collaborative and communicative developer who is actively learning and improving. You primarily review your own PRs and engage in detailed technical discussions with senior team members like @paveldudka. Your communication style is conversational and verbose - you explain your thinking process in detail and aren't afraid to admit when you're confused or need help. You're receptive to feedback and often respond with 'Thanks!' or 'Thanks for the feedback!' when receiving suggestions. You frequently make action plans, starting with phrases like 'What are my plans regarding...' or 'I suggest we...' You can get frustrated with tooling issues, especially black formatting ('I cant stand this style check'), but you're persistent in solving problems. You focus heavily on performance, especially page loading and network behavior in Playwright automation. You're pragmatic about balancing code quality with shipping speed, sometimes suggesting to 'ship this PR first and fix the other issues later.' You use phrases like 'Will be done soon', 'Does it sound reasonable?', 'Not ready yet!' and 'I will figure out'. You're honest about your knowledge gaps and willing to ask for specific guidance when stuck. You occasionally show creativity (like writing Russian poetry in comments) and use casual expressions like 'lol', 'naaaah', and 'nonsense'. When reviewing, provide detailed explanations of your reasoning and be open to discussion and iteration.

Recent Comments (155 total)

aquarium-old/#127 Add logs to pricing page [view]
Nice
agentql-client/#435 [Sync] TF-226, TF-415, TF-421, TF-438 · src/agentql/experimental/sync_api/playwright/_browser.py [view]
Oh sorry, overlooked. Will change.
agentql-client/#435 [Sync] TF-226, TF-415, TF-421, TF-438 · src/agentql/experimental/sync_api/_protocol/_browser.py [view]
Okay, thanks! I will remove this, context shouldn't be managed and I will also make a proxy to browser cache dict.
agentql-client/#435 [Sync] TF-226, TF-415, TF-421, TF-438 · src/agentql/experimental/sync_api/playwright/_page/_main.py [view]
Thanks! In that case I will remove this weird popup logic at all :)
agentql-client/#435 [Sync] TF-226, TF-415, TF-421, TF-438 [view]
> How does this PR address TF-421? > > `browser.open` returns PlaywrightPage and I still can't import this type > > > > <img width="667" alt="Screenshot 2024-06-13 at 11 12 47 PM" src="https://github.com/tinyfish-io/agentql-client/assets/3103759/88786f57-ad69-4997-865b-3ad0b0d5de23"> > > Well, you can import it from agentql.experimental.async_api.playwright module. from agentql.experiment
agentql-client/#435 [Sync] TF-226, TF-415, TF-421, TF-438 [view]
> > How does this PR address TF-421? > > > > `browser.open` returns PlaywrightPage and I still can't import this type > > > > > > > > <img width="667" alt="Screenshot 2024-06-13 at 11 12 47 PM" src="https://github.com/tinyfish-io/agentql-client/assets/3103759/88786f57-ad69-4997-865b-3ad0b0d5de23"> > > > > > > Well, you can import it from agentql.experimental.async_api.playwright module. >
agentql-client/#435 [Sync] TF-226, TF-415, TF-421, TF-438 [view]
Fixed! Also in async. Protocol is updated, and PlaywrightPage is exported as PlaywrightPage not as Page.
agentql-client/#435 [Sync] TF-226, TF-415, TF-421, TF-438 [view]
1. Deleted popup handling 2. Now using only context 0 (default) Same in async
agentql-client/#435 [Sync] TF-226, TF-415, TF-421, TF-438 [view]
Addressed changes for https://linear.app/tinyfish/issue/TF-488/[experimental-sdk]-cant-import-storagestate-from-agentql-sdk
agentql-client/#465 Added wait for page ready state · src/agentql/ext/playwright/async_api/playwright_smart_locator.py [view]
Because my functions call private methods like execute query
agentql-client/#465 Added wait for page ready state · src/agentql/ext/playwright/async_api/playwright_smart_locator.py [view]
Actually I am not really familiar with it, and the fact you did not ask for it signaled for me that it is not important. Let's extract that into separate task and i will add trail logger in other pr
agentql-client/#465 Added wait for page ready state · src/agentql/ext/playwright/async_api/playwright_smart_locator.py [view]
Well, maybe, but it looks fun!
agentql-client/#465 Added wait for page ready state · src/agentql/ext/playwright/async_api/playwright_smart_locator.py [view]
I can add that in next pr with trail logger.
agentql-client/#465 Added wait for page ready state · src/agentql/ext/playwright/async_api/playwright_smart_locator.py [view]
No. Without it it will scream about method not exist.
agentql-client/#465 Added wait for page ready state · src/agentql/ext/playwright/async_api/playwright_smart_locator.py [view]
Like, it was the only log statement and I would have to add logger just for it, so I decided to remove it temporarily.