@shuhaodo
constructive and collaborative
A collaborative and detail-oriented reviewer who combines technical precision with constructive feedback. Frequently offers specific code suggestions and asks thoughtful questions to understand context and best practices.
1944
Comments
1442
PRs
30
Repos
43988
Avg Chars
2
Harshness
Personality
Detail-oriented and thorough
Collaborative and team-focused
Pragmatic problem-solver
Quality-conscious
Appreciative of good work
Methodical in approach
Forward-thinking about edge cases
Documentation-focused
Greatest Hits
"what's the best practice here?"
"wrap_async is brilliant"
"much better!"
"great work!"
"great catch!"
"looks good"
"makes sense"
Focus Areas
- code correctness
- best practices
- API consistency
- documentation accuracy
- error handling
- performance implications
- edge case handling
- backwards compatibility
Common Phrases
"good suggestion"
"great work"
"should we"
"what's the best practice here?"
"we can"
"this will"
"need to"
"just to"
"looks good"
"makes sense"
"brilliant"
"much better!"
"great catch!"
"nice finding!"
Sentiment Breakdown
Review Outcomes
Most Reviewed Authors
Spiciest Comments
Do we need to duplicate runs?
Even if we dup runs, streamingUrl won't work here
If Alguna returns 429, can we allow the API call instead of rejecting? We may allow some extra API calls but this is a better use experience
`get_by_prompt` doesn't work with the structured query. Should we add another paragraph just for get_by_prompt?
GPT4T is 128k. Having a 4k max_tokens will reject most of the FACTs.
The model doesn't work just yet. It requires additional prompt engineering. Another PR coming.
Checked with @bellatinyfish, all the comments have been resolved, with @zifanwTF's approval, I'll force merge as @mingyang-tinyfish is on vocation and unable to resolve his requested changes.
# State **`s3://tinyfish-aws-control-prod-agentql-logs/terraform.tfstate`**
## Affected resources counts
| Success | 🟢 Add | 🟡 Change | Destroy |
|:---------:|--------:|-----------:|-----------:|
| ✅ | 26 | 2 | 0 |
## Affected resources by action
| Action | Resources |
|:--------:|:-------------------------------------------------
# State **`s3://tinyfish-aws-control-prod-agentql-logs/terraform.tfstate`**
## Affected resources counts
| Success | Add | 🟡 Change | Destroy |
|:---------:|-------:|-----------:|-----------:|
| ✅ | 0 | 4 | 0 |
## Affected resources by action
| Action | Resources |
|:--------:|:------------------------------------------------------------------------------------|
| 🟡 | `m
# State **`s3://tinyfish-aws-control-prod-agentql-logs/terraform.tfstate`**
## Affected resources counts
| Success | 🟢 Add | 🟡 Change | Destroy |
|:---------:|--------:|-----------:|-----------:|
| ✅ | 26 | 2 | 0 |
## Affected resources by action
| Action | Resources |
|:--------:|:-------------------------------------------------
# State **`s3://tinyfish-github-control/terraform.tfstate`**
## Affected resources counts
| Success | 🟢 Add | Change | Destroy |
|:---------:|--------:|----------:|-----------:|
| ✅ | 8 | 0 | 0 |
## Affected resources by action
| Action | Resources |
|:--------:|:-------------------------------------------------------------------------------|
| 🟢 | `module.repos["fish-tank"].
AI Persona Prompt
You are @shuhaodo, a collaborative and detail-oriented code reviewer who focuses on technical precision and best practices. Your reviews are constructive and thorough, often including specific code suggestions using GitHub's suggestion format. You frequently ask questions like 'what's the best practice here?' and 'should we...' to understand context and explore alternatives. You're generous with praise, using phrases like 'brilliant', 'great work!', 'great catch!', and 'much better!' when appropriate. You pay close attention to API consistency, documentation accuracy, error handling, and backwards compatibility. When reviewing, you often propose specific improvements and explain your reasoning. You're not afraid to point out potential issues but do so constructively, often offering solutions or asking for clarification. You tend to think about edge cases and long-term maintainability. Your tone is collaborative rather than prescriptive - you see yourself as a teammate helping to improve the code. You often use phrases like 'we can', 'we should', and 'looks good' to maintain a collaborative atmosphere. When you spot something particularly well done, you're quick to acknowledge it with enthusiasm.
Recent Comments (1608 total)
how are the template files populated in AWS?
Do we need to duplicate runs?
Even if we dup runs, streamingUrl won't work here
update to valid browser types
valid ones:
tetra
tetra-anchor
Valid browser types:
tetra
tetra-anchor
"chromium" is not a valid browser type. Supported browsers are: "tetra", "tetra-anchor"
"proxy" only takes in country code. If not specified, it's equivalent to disabled. e.g. "proxy": "US". "proxy":""
"proxy" only takes in country code. If not specified, it's equivalent to disabled. e.g. "proxy": "US". "proxy":""
- Some enum fixes.
- are `evb` folders still needed?
CSV columns should be dynamically defined from the data.
We should make it 50MB
review how to invoke playground API, can we directly call the action
review how this is setup; document the ENV vars so they can be set up properly when deployed
railway should be removed
browser_type: 'tetra' | 'tetra-anchor'
proxy_country_code = 'US' | '' | other codes
proxy_enabled not needed.
flatten the config and fix the browser_type values
browser_type: 'tetra' | 'tetra-anchor'
proxy_country_code = 'US' | '' | other codes
proxy_enabled is not needed.